Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about relative URIs in "type" and "instance" #20

Merged
merged 5 commits into from May 25, 2021
Merged

Warn about relative URIs in "type" and "instance" #20

merged 5 commits into from May 25, 2021

Conversation

mnot
Copy link
Member

@mnot mnot commented Apr 26, 2021

This necessitated rearranging the section on members for clarity.

Also, "Consumers MUST use the 'type' string..." was changed to
"Consumers MUST use the 'type' URI..." for consistency.

Fixes #11.

@mnot
Warn about relative URIs in "type" and "instance"
ce8340d 
This necessitated rearranging the section on members for clarity.

Also, "Consumers MUST use the 'type' string..." was changed to
"Consumers MUST use the 'type' URI..." for consistency.

Fixes #11.
@mnot mnot mentioned this pull request Apr 26, 2021
Closed
asbjornu
asbjornu reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement and that it resolves the issue. I would just like a bit more verbosity in the example given for relative URIs.

draft-ietf-httpapi-rfc7807bis.md Outdated Show resolved Hide resolved
draft-ietf-httpapi-rfc7807bis.md Show resolved Hide resolved
draft-ietf-httpapi-rfc7807bis.md Show resolved Hide resolved
draft-ietf-httpapi-rfc7807bis.md Outdated Show resolved Hide resolved
mnot and others added 2 commits April 26, 2021 14:53
@mnot @asbjornu
Update draft-ietf-httpapi-rfc7807bis.md
96c755c 
Co-authored-by: Asbjørn Ulsberg <asbjorn@ulsberg.no>
@mnot
update instance text
8d7a808
pimterry
pimterry approved these changes Apr 26, 2021
View reviewed changes
Copy link

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of quick thoughts on ways this could go slightly further, but I think this is already a great improvement that would fix #14.

draft-ietf-httpapi-rfc7807bis.md Outdated Show resolved Hide resolved
draft-ietf-httpapi-rfc7807bis.md Outdated Show resolved Hide resolved
asbjornu
asbjornu approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mnot mnot merged commit aa4ec77 into main May 25, 2021
@mnot mnot deleted the mnot-11 branch May 25, 2021 06:56
@mnot mnot mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornu asbjornu asbjornu approved these changes

@pimterry pimterry pimterry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should 'type' definitely be required to be a URI?
3 participants
@mnot @asbjornu @pimterry