Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F3-CAR-Issue-3: Handling of LCM and Extended Communities #3

Closed
sa1231-coder opened this issue Jan 3, 2023 · 11 comments
Closed

F3-CAR-Issue-3: Handling of LCM and Extended Communities #3

sa1231-coder opened this issue Jan 3, 2023 · 11 comments

Comments

@sa1231-coder
Copy link
Collaborator

-Appendix B.2 should be clarified after F3-CAR-Issue-2 has been expanded to include:
>CAR Sections 1.1 needs indicate that local BGP policy can customize or adjust the route validation (section 2.4), route resolution (2.5), and AIGP (2.6).
>Section 2.10 should cover any issues regarding conflicts caused by local policy.

@sa1231-coder
Copy link
Collaborator Author

Section 2.9.3 is updated to use LCM-EC color when present for route validation, resolution and AIGP.
Section 2.10 is added to explicitly state LCM-EC and BGP Color EC usage.

@suehares
Copy link
Collaborator

suehares commented Mar 3, 2023

F3-CAR-Issue 3: Handling of LCM and Extended Communities

Shepherd Comment: The text that is changed is below in bold:

When a CAR route crosses the originator's color domain boundary, LCM-
EC is added. LCM-EC conveys the local color mapping for the intent
(e.g. low latency) in other (transit or destination) color domains.

An implementation SHOULD NOT send more than one instance of the LCM-
EC. However, if more than one instance is received, an
implementation MUST disregard all instances other than the one with
the numerically highest value.

If present, LCM-EC is the effective intent of a BGP CAR route.

LCM-EC Color is used instead of the Color in CAR route NLRI for
procedures described in earlier sections such as route validation,
resolution, AIGP calculation and steering.

The new section 2.10 is a nice addition to the CAR draft. Please verify that the following pairing in that text is accurate:

  1. section 2.5 (mechanism), section B.2 example,
  2. section 2.8 (mechanism) , section B.3 Example.

After you finish the IDR Review of F3-CAR-Issue-2, you may want to go on to cover this issue before F3-CAR-Issue-3 in a specific all.

This issue is not resolved until you complete the IDR WG mail call of your issues.

@suehares
Copy link
Collaborator

suehares commented Mar 3, 2023

This issue needs to be re-opened.

@suehares suehares reopened this Mar 3, 2023
sa1231-coder added a commit that referenced this issue Mar 25, 2023
#3 
Section 2.9.3 is updated to use LCM-EC color when present for route validation, resolution and AIGP.
Section 2.10 is added to explicitly state LCM-EC and BGP Color EC usage.
@suehares
Copy link
Collaborator

suehares commented Jun 1, 2023

Sue will re-read new section 2.10 for answering question F3-CAR-Issue-3. (Thursday night).

DJ and Swadesh consider adding a comment that points to RFC9012 color not being used.

@suehares
Copy link
Collaborator

suehares commented Jun 4, 2023

Error handling in section 2.9.2.2

This TLV provides the equivalent functionality as Label-Index TLV of
[RFC8669] for Transport CAR route in SR-MPLS deployments. It
provides much better packing efficiency by carrying label Index in
NLRI instead of the BGP Prefix SID attribute. The BGP Prefix SID
Attribute SHOULD be omitted from the labeled color-aware routes when
the attribute is being used to only convey the Label Index TLV.

Editor's comments:
What happens if the "SHOULD" is not followed? Does the BGP Prefix SID Attribute get ignored?

If so, please indicate this at this point.

@suehares
Copy link
Collaborator

suehares commented Jun 4, 2023

Section 2.10 refers to sections B.2, 2.5, 2.8, and B.3. Section 2.5 refers to section A.3.2. Section 2.8 refers to Appendix B. All of these sections were reviewed in the review of section 2.10.

Section 2.10
Text:
Both LCM-EC and BGP Color Extended Community may be present with a BGP
CAR route. Example: BGP CAR route (E, C1) from color domain D1, with
LCM-EC C2 in color domain D2, may also carry Color-EC C3 and next-hop
N in a transit network domain within D2 that has intent C3 available
and resolves C2 via C3

It is "Color-EC C3" or LCM-EC C3",? The color is on:

  1. NLRI,
  2. LCM Extended community, and
  3. Color-EC C3

It the Color-EC C3 applied by local policy in mapping to the transport?

I'm having trouble mapping this text to the example in B.3.

@suehares
Copy link
Collaborator

suehares commented Jun 4, 2023

Sue's note. I'll re-read sections 2.10, B.2, 2.5, 2.8, and B.3 again on Monday (6/5) prior to our chat.

@dhrao1
Copy link
Collaborator

dhrao1 commented Jun 9, 2023

The text above refers to a combination case where both LCM-EC and Color-EC are present on a CAR route. The behavior is a combination of examples in Appendix B.2 and B.3.

As described in Appendix B.2, the next-hop color (C3 in above text) may be mapped by local policy on an ingress BR within color domain D2, or by attaching the Color-EC at an egress BR within color domain D2.

Note:
NLRI color is C1
LCM-EC color is C2 (since different color domain D2)
Color-EC color is C3 (in a transit domain within color domain D2 where C2 is being resolved via intra-domain intent C3)

@suehares
Copy link
Collaborator

suehares commented Jun 9, 2023

Editorial: Appendix.B.3 - lacks the link.

Since the example comes from sections B.2 and B.3, I was trying to determine how to indicate this fact to the readers of the text. Do you have any suggestions?

sa1231-coder added a commit that referenced this issue Jun 13, 2023
#3 
updated text indicating applicability of both appendix B.2 and B.33.
sa1231-coder added a commit that referenced this issue Jun 16, 2023
@suehares
Copy link
Collaborator

I consider this issue ready for external review.

@sa1231-coder
Copy link
Collaborator Author

Comment/clarification were addressed in draft-ietf-idr-bgp-car-02. After that WG has been polled with WGLC and no further comments have been raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants