Clarify wrapping filter expressions in parentheses #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that this is not required, unlike in the original JSONPath article. Also, avoid using such parentheses in examples for consistency.
timbray
reviewed
Aug 8, 2023
draft-ietf-jsonpath-base.md
Outdated
| @@ -1173,6 +1173,11 @@ They have the normal semantics of Boolean algebra and obey its laws | |||
| (see, for example, {{BOOLEAN-LAWS}}). | |||
| Parentheses MAY be used within `logical-expr` for grouping. | |||
|
|
|||
| It is not required that `logical-expr` consist of | |||
| a parenthesized expression (which was required in {{JSONPath-orig}}), | |||
| although it can be and the semantics are the same | |||
There was a problem hiding this comment.
Yes, I think that works well. Added.
timbray
approved these changes
Aug 8, 2023
cabo
reviewed
Aug 8, 2023
| @@ -1173,6 +1173,11 @@ They have the normal semantics of Boolean algebra and obey its laws | |||
| (see, for example, {{BOOLEAN-LAWS}}). | |||
| Parentheses MAY be used within `logical-expr` for grouping. | |||
|
|
|||
| It is not required that `logical-expr` consist of | |||
There was a problem hiding this comment.
We now have removed all examples that actually show what is discussed here?
(We know what it is, but readers may not.)
There was a problem hiding this comment.
Yes, I was a little concerned about that too, so I've added a specific example near the top of the filter example table.
cabo
approved these changes
Aug 8, 2023
gregsdennis
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that this is not required, unlike in the original JSONPath article. Also, avoid using such parentheses in examples for consistency.