Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify ICMP outside of scoping target #157

Merged
merged 2 commits into from Apr 13, 2023
Merged

Clarify ICMP outside of scoping target #157

merged 2 commits into from Apr 13, 2023

Conversation

DavidSchinazi
Copy link
Collaborator

evyncke
evyncke approved these changes Apr 13, 2023
View reviewed changes
Copy link

@evyncke evyncke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is better, even if I would have prefer to have the last sentence standing on its own, i.e., in a one-sentence paragraph (but this is cosmetic). Thanks for addressing this part of my DISCUSS.

@DavidSchinazi DavidSchinazi merged commit 57f6610 into main Apr 13, 2023
2 checks passed
@DavidSchinazi DavidSchinazi deleted the icmp_scope branch April 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfpauly tfpauly tfpauly approved these changes

@evyncke evyncke evyncke approved these changes

@gloinul gloinul gloinul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DavidSchinazi @tfpauly @evyncke @gloinul