Split up link operation and router operation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfpauly
approved these changes
Apr 19, 2023
Co-authored-by: Tommy Pauly <tpauly@apple.com>
gloinul
reviewed
Apr 20, 2023
| where the IPv6 minimum link MTU is violated. IP proxying endpoints that operate | ||
| as routers and support IPv6 MUST ensure that the IP tunnel link MTU is at least | ||
| 1280 (i.e., that they can send HTTP Datagrams with payloads of at least 1280 | ||
| bytes). This can be accomplished using various techniques: |
There was a problem hiding this comment.
This one is a bit complex. In some sense it it the link responsibility to ensure that it supports a MTU of at least 1280. At the same time we have put the verification aspect onto the router to verify that an 1280 bytes MTU encapsulated packet will make it through. So the first bullet below still works. But, the second ones creates this strange interaction where the router needs to ping the other end of the tunnel, and if the min MTU ping fails consistently then withdraw the route until it succeeds.
There was a problem hiding this comment.
I agree with you. I don't see a better solution though, so I think we'll have to live with this bit not fitting in perfectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165