Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix178 #183

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix178 #183

merged 1 commit into from
Sep 28, 2023

Conversation

DavidSchinazi
Copy link
Collaborator

Fixes #178

@DavidSchinazi DavidSchinazi changed the base branch from main to auth48 September 25, 2023 16:16
@gloinul
Copy link
Collaborator

gloinul commented Sep 25, 2023

So this is better, but I would note that the sentence ("If the recipient is configured to use another HTTP server ...") is actually biased towards an HTTP Gateway, i.e. an HTTP server side HTTP Intermediary rather than also cover client side HTTP Proxy. As this type of proxies the client are configured to use them, but they will process the HTTP request and determine how to forward it based on the host information in the request.

@DavidSchinazi
Copy link
Collaborator Author

@gloinul I agree with you that the common instance is that of a gateway, but the term intermediary is also correct. Are you suggesting a change to this PR or are you OK with it?

@gloinul
Copy link
Collaborator

gloinul commented Sep 25, 2023

I think it is the word "configure" that I have issue with. As the recipient doesn't need to be configured to use another HTTP server, just to be a HTTP intermediary. I think what would be clearer are:

"If the recipient is configured to be an HTTP intermediary, it will forward the request to a HTTP server or another HTTP intermediary."

This sentence is just to provide a context for when the following note applies.

@DavidSchinazi
Copy link
Collaborator Author

If the recipient is configured to be an HTTP intermediary, it will forward the request to a HTTP server or another HTTP intermediary.

That's not quite right, an HTTP intermediary is an HTTP server - the server is simply defined as the one who receives the request and sends the response. In other words, an intermediary is both an HTTP client and an HTTP server, but in this case it's the server half that's relevant. So it doesn't make sense to say "to a HTTP server or another HTTP intermediary".

We could therefore imagine saying the following:

If the recipient is configured to be an HTTP intermediary, it will forward the request to another HTTP server.

But at that point I prefer the text in this PR, I find it more clear.

@DavidSchinazi
Copy link
Collaborator Author

@gloinul do you have any more thoughts? This is the last remaining discussion point, it would be nice for us to resolve it.

@DavidSchinazi DavidSchinazi merged commit ef9a9be into auth48 Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUTH48: Wrong use of HTTP Proxy
3 participants