New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clear that proxy metadata must be known to the client #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to be clearer about the client knowing the type of information that is added, though it might be ignorant of the specific value the proxy chooses?
We could list examples, but it would be a non-exhaustive list that might end up harming more than helping, so I'm inclined to omit that for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small suggestions here. I think that we need to sharpen the distinction between knowledge of the type of information that might be added and the specific value that is added.
A small nit about the halving thing made me think a little...
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM
Co-authored-by: Shivan Kaul Sahib <shivankaulsahib@gmail.com>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Split out from #96, since the shadowban bit needs more consideration in relation to target->proxy signals like rate limits.
Closes #100.
cc @ekr