Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that proxy metadata must be known to the client #113

Merged
merged 7 commits into from Jun 17, 2022

Conversation

chris-wood
Copy link
Collaborator

@chris-wood chris-wood commented Mar 28, 2022

Split out from #96, since the shadowban bit needs more consideration in relation to target->proxy signals like rate limits.

Closes #100.

cc @ekr

Copy link
Collaborator

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be clearer about the client knowing the type of information that is added, though it might be ignorant of the specific value the proxy chooses?

@chris-wood
Copy link
Collaborator Author

Do we need to be clearer about the client knowing the type of information that is added, though it might be ignorant of the specific value the proxy chooses?

We could list examples, but it would be a non-exhaustive list that might end up harming more than helping, so I'm inclined to omit that for now.

Copy link
Collaborator

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small suggestions here. I think that we need to sharpen the distinction between knowledge of the type of information that might be added and the specific value that is added.

A small nit about the halving thing made me think a little...

draft-ietf-ohai-ohttp.md Outdated Show resolved Hide resolved
draft-ietf-ohai-ohttp.md Outdated Show resolved Hide resolved
chris-wood and others added 3 commits June 15, 2022 08:52
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
draft-ietf-ohai-ohttp.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

draft-ietf-ohai-ohttp.md Outdated Show resolved Hide resolved
draft-ietf-ohai-ohttp.md Outdated Show resolved Hide resolved
chris-wood and others added 2 commits June 16, 2022 05:59
Co-authored-by: Shivan Kaul Sahib <shivankaulsahib@gmail.com>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
@martinthomson martinthomson merged commit 368c576 into main Jun 17, 2022
@martinthomson martinthomson deleted the caw/metadata-agreement branch June 17, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding demographic metadata (e.g., geo)
4 participants