Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less use of Title Case #224

Closed
wants to merge 8 commits into from
Closed

Less use of Title Case #224

wants to merge 8 commits into from

Conversation

martinthomson
Copy link
Collaborator

This is a big change, but I think that I like it. The cost is fairly minimal, but it reads a little better in my view.

Also, I fixed a few very minor typos. If we don't go this way, then I'll have to find those and fix them.

On the other hand, there are open pull requests that will need to be fixed in line with this change if we do.

@mnot
Copy link
Contributor

mnot commented Dec 5, 2022

+1 this reads much more clearly.

Copy link
Collaborator

@chris-wood chris-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should take this change this late in the process. This document went through WGLC and the consensus at the time was to treat the terms as proper nouns. I don't think it's appropriate to change it now on the basis of a single review. Beyond that, I don't think this meaningfully improves readability, but I don't feel strongly about it.

@tfpauly
Copy link
Collaborator

tfpauly commented Dec 5, 2022

Hm, I don't think this is an improvement — it particularly seems odd to force lowercase all of the terms in definitions, even where it seems more correct to have them capitalized.

@mnot
Copy link
Contributor

mnot commented Dec 6, 2022

I Think It's An Improvement, But Obviously This Is A Matter Of Taste.

martinthomson added a commit that referenced this pull request Dec 12, 2022
We weren't always capitalizing "Encapsulated Request".  This does more,
in direct opposition to the changes in #224.  If we don't take that (it
seems we at an impasse there), then we should at least be consistent.
@martinthomson
Copy link
Collaborator Author

We're at something of an impasse here, so in the interests of getting shit done, I'm dropping this. I'll have to read through and find those tiny tweaks and apply them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants