Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of REST API #3

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Cleanup of REST API #3

merged 6 commits into from
Feb 22, 2023

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented Feb 17, 2023

This PR is a duplicate of what had already been reviewed in the old repository:

ietf-scitt/draft-birkholz-scitt-architecture#44

@letmaik letmaik mentioned this pull request Feb 17, 2023
Closed
thomas-fossati
thomas-fossati reviewed Feb 17, 2023
View reviewed changes
Copy link

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my API concerns from the previous round.

I have left a couple of purely editorial comments.

draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
draft-ietf-scitt-architecture.md Show resolved Hide resolved
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
thomas-fossati
thomas-fossati approved these changes Feb 17, 2023
View reviewed changes
Copy link

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

I think eventually the API stuff should be moved into its own "SCITT API" document.

This was referenced Feb 17, 2023
Merged
Closed
@letmaik letmaik requested a review from JAG-UK February 19, 2023 21:25
@yogeshbdeshpande
Copy link
Collaborator

@letmaik I am reviewing it now!

yogeshbdeshpande
yogeshbdeshpande reviewed Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the API set looks quite tidy, left few minor .nits, please check and incorporate them.

@letmaik letmaik mentioned this pull request Feb 22, 2023
Closed
@letmaik
Copy link
Contributor Author

letmaik commented Feb 22, 2023

@yogeshbdeshpande Thanks for the review. I addressed your comments, please approve if you think it's good to go.

yogeshbdeshpande
yogeshbdeshpande approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yogeshbdeshpande
Copy link
Collaborator

@letmaik DONE!

@letmaik letmaik merged commit 2056dc9 into ietf-wg-scitt:main Feb 22, 2023
@letmaik letmaik deleted the letmaik/rest-api branch February 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@henkbirkholz henkbirkholz Awaiting requested review from henkbirkholz henkbirkholz is a code owner

@JAG-UK JAG-UK Awaiting requested review from JAG-UK JAG-UK is a code owner

@fournet fournet Awaiting requested review from fournet fournet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@letmaik @yogeshbdeshpande @thomas-fossati