Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add commit lint #8

Merged
merged 1 commit into from Sep 21, 2017
Merged

feat(lint): add commit lint #8

merged 1 commit into from Sep 21, 2017

Conversation

jvcjunior
Copy link
Member

  • Checks if the commit message is meeting project standards
  • Checks there's no eslint error/warning on the commited files

issue: #4

- Checks if the commit message is meeting project standards
- Checks there's no eslint error/warning on the commited files

issue: #4
Copy link

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Tested it and it works great.
What I suggest though is to add the rules to WIKI in order to make it accessible to anyone that doesn't know about it.

It would be great if, in case of commit error, the output message was something like:
In case you don't know the commit rules of this project, please refer to https://github.com/ifactory-solutions/wiki-url-with-commit-rules.

@paulonotz0r
Copy link
Contributor

Nice! Works like a charm when I've tested it!

Copy link
Contributor

@Jefferson227 Jefferson227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked very well on Linux, but if you are using Windows you must attempt to the "End of Line Sequence" configuration which must be LR instead of CRLF (I believe it's a subject for another issue).

And I agree with @yannbf regarding to put a link to a WIKI just to provide some orientation about our commit message standards for those who want to contribute to the project.

Copy link
Contributor

@wellyal wellyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, seems to work well congrats :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants