Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chronomodel breaks compatibility with the upcoming FactoryBot Rails 6.3.0 #231

Closed
tagliala opened this issue Sep 23, 2023 · 1 comment · Fixed by #232
Closed

Chronomodel breaks compatibility with the upcoming FactoryBot Rails 6.3.0 #231

tagliala opened this issue Sep 23, 2023 · 1 comment · Fixed by #232
Labels
bug

Comments

@tagliala
Copy link
Member

tagliala commented Sep 23, 2023 •
edited

Bisected to: thoughtbot/factory_bot_rails#419

NoMethodError: undefined method `config' for nil:NilClass
~/.rvm/gems/ruby-3.2.2/gems/railties-7.0.8/lib/rails.rb:47:in `configuration'
~/gems/ruby-3.2.2/bundler/gems/factory_bot_rails-659d74ae636c/lib/factory_bot_rails/railtie.rb:25:in `block in <class:Railtie>'

Live demo: https://github.com/diowa/ruby3-rails7-bootstrap-heroku/tree/experimental/chrono-factory-bot-main

Proably chronomodel is hooking into Railties in a wrong way, since the default postgres adapter works
@tagliala tagliala added the bug label Sep 23, 2023
@tagliala tagliala changed the title Chronomodel breaks compatibility with FactoryBot Rails 6.3.0 Chronomodel breaks compatibility with the upcoming FactoryBot Rails 6.3.0 Sep 23, 2023
@tagliala
Copy link
Member Author

chronomodel/lib/chrono_model.rb

Lines 40 to 48 in 7362608

ActiveRecord::Base.instance_eval do
# Checks whether this Active Recoed model is backed by a temporal table
#
def chrono?
return false unless connection.respond_to? :is_chrono?
connection.is_chrono?(table_name)
end
end

tagliala added a commit that referenced this issue Sep 24, 2023
@tagliala
Use active support on load hooks
f3d5731 
Close #231
@tagliala tagliala mentioned this issue Sep 24, 2023
Merged
3 tasks
tagliala added a commit that referenced this issue Sep 24, 2023
@tagliala
Use active support on load hooks
3898582 
Close #231
tagliala added a commit that referenced this issue Sep 24, 2023
@tagliala
Use active support on load hooks
fd6272d 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support on load hooks
90ffe1e 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support on load hooks
110112a 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support on load hooks
bf389fd 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support on load hooks
928d8a5 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support on load hooks
0237900 
Close #231
tagliala added a commit that referenced this issue Oct 8, 2023
@tagliala
Use active support lazy load hooks
b4f097e 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 16, 2023
@tagliala
Use active support lazy load hooks
f66edd0 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 19, 2023
@tagliala
Use active support lazy load hooks
ee346f6 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 19, 2023
@tagliala
Use active support lazy load hooks
7eba89b 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 19, 2023
@tagliala
Use active support lazy load hooks
b98fa60 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 19, 2023
@tagliala
Use active support lazy load hooks
c4611b7 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Oct 20, 2023
@tagliala
Use active support lazy load hooks
7676fda 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Nov 1, 2023
@tagliala
Use active support lazy load hooks
ae1d9b7 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426


Close #231
tagliala added a commit that referenced this issue Nov 4, 2023
@tagliala
Use active support lazy load hooks
a49a3bf 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Ref: thoughtbot/factory_bot_rails#426

Close #231
tagliala added a commit that referenced this issue Nov 4, 2023
@tagliala
Use Active Support lazy load hooks
78bc0cd 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Also:
- Require Railtie as suggested by APIs
- Patch DBConsole only if needed
- Move application configuration check in an after initialize lazy load hook
  to be sure that `Rails.application` is available at the moment of the check

Ref:
- thoughtbot/factory_bot_rails#426
- https://edgeapi.rubyonrails.org/classes/Rails/Railtie.html#class-Rails::Railtie-label-Creating+a+Railtie

Close #231
tagliala added a commit that referenced this issue Nov 4, 2023
@tagliala
Use Active Support lazy load hooks
869454a 
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has
been fully loaded.

Also:
- Require Railtie as suggested by APIs
- Patch DBConsole only if needed
- Move application configuration check in an after initialize lazy load hook
  to be sure that `Rails.application` is available at the moment of the check

Ref:
- thoughtbot/factory_bot_rails#426
- https://edgeapi.rubyonrails.org/classes/Rails/Railtie.html#class-Rails::Railtie-label-Creating+a+Railtie

Close #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Active Support lazy load hooks ifad/chronomodel
1 participant
@tagliala