libreoffice text conversion adn specs fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| executioner.execute( | ||
| 'pdftotext', | ||
| pdf_file, |
There was a problem hiding this comment.
I don't think we need this extra pdf_file variable, "#{job.content_file}.pdf" is enough.
|
@vjt fixed and commented |
| 'pdftotext', | ||
| "#{job.content_file}.pdf", | ||
| target_file | ||
| ) |
There was a problem hiding this comment.
This doesn't look right, if to_suffix is txt convert it to a PDF?
There was a problem hiding this comment.
Oh I see, you convert it from OO -> PDF -> TXT 😄
There was a problem hiding this comment.
Yes @lucaspiller because OO -> TXT is not working right for xlsx and ppt
vjt
added a commit
that referenced
this pull request
Jan 15, 2016
libreoffice text conversion and specs fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please @vjt review when you can