Generate icon when saving configuration

[YPYDKZVAGGDCBWPJ2J6ZQALY]

Open PS2 loader version

0.9.3

Issue description - Describe the problem you are having

When OPL configuration is saved to the memory card, the directory does not contain an icon.sys file. Because of this, the folder appears as corrupted within the PS2’s built-in Browser.

[ShaolinAssassin]

It's supposed to be fixed since a long time (Oct 23, 2015, commit 4a05293). You can either download this file here or update to last OPL beta build (https://akuhak.github.io/test_build/opl.zip).

[TnA-Plastic]

@fumu-no-kagomeko: So did a newer build fix the issue for you?

@ShaolinAssassin: The builds from Akuhak's script currently do not work.

[YPYDKZVAGGDCBWPJ2J6ZQALY]

Ah, sorry for just opening an issue and disappearing. _ don’t really use _ PlayStation 2 as of late.

With version 0.9.3+ 1152-Beta-58a493e the icon appears when the configuration is created anew, but when saving with the folder already existing, the icon is not created.

[TnA-Plastic]

@fumu-no-kagomeko:

This should be fixed once @Tupakaveli 's PR (KrahJohlito' s code it seems) has been merged!

[KrahJohlito]

One thing I am curious about as I seem to recall seeing something in the code about it...somewhere...

Do all MC Icons get written as the same file size so its not possible to compare sizes and overwrite if there is a difference?.. or was that just SYS Icons or something?

[TnA-Plastic]

AFAIR, both can differ in size!
ICO-Files are different in size in most cases.
SYS-Files are usually quite the same in size, BUT since they can link to 3 icons(!!! Main, Delete, Copy) it should vary as well.

Hash-checking would work as well, but would need to read the present file, which would need extra-time...

Edit: On another note, I don't think that an icon which is present should be checked and if not like the internal one 'replaced', due to the fact that some people might want to use their own icons (+ takes extra-time to read and reads from the device-blocks in the first place, just for that check...)!

[KrahJohlito]

Edit: On another note, I don't think that an icon which is present should be checked and if not like the internal one 'replaced', due to the fact that some people might want to use their own icons (+ takes extra-time to read and reads from the device-blocks in the first place, just for that check...)!

yea fair point, it was more so just to update the icon since it has been replaced with a newer one... didn't think about users custom icons though..

https://github.com/ifcaro/Open-PS2-Loader/blob/5cb5de5f4734311749499d766e21b76a690be99b/src/OSDHistory.c#L54

I did find what I was referring too, it appears to continually write the file even if no data but I don't know if that's relevant to MC Icons anyway.

[J013k]

Little bit off topic.
Do we need to create MC icon for every device?

I mean, currently when you'll attach HDD, at boot OPL will create separate partition (+OPL).
This partition with folders will have all the needed content.
I mean it can have settings, themes, translations, game settings,
so creating almost blank MC icon (in OPL folder there will be only icon.sys & lol.icn) is a bit pointless.

I don't know what to do with USB devices, theoretically it can also have all the needed content,
but in most causes this device is removable...
For SMB there is currently no hope. ;)

Maybe if OPL will find settings on other device, it'll no need to create MC icon?
If somehow there is empty OPL folder on, OPL should create icons to avoid corrupted data in MC browser.
If settings on other devices will not be found, MC icon with settings will be create after saving these settings.

[KrahJohlito]

@J013k
https://www.sendspace.com/file/7iucmp

This should fix all of the above...including this issue.
OPL folder and MC icon will be checked upon saving to mc? and written if not found.. mcID is now determined by sysCheckMC ret value rather than if it can mk or read dir.

[J013k]

I've tried this test build for short period of time through USB.
I've deleted OPL folder from MC, launched OPL from USB device (config was loaded from mass:),
saved settings (settings was saved into mass:).
Only config files on mass were updated, no additional OPL folder on MC was created.

I've also unplugged USB device, saved settings on MC.
On memory card OPL folder with settings and icon has been created.

I'm currently not sure how this test build will work through SMB or HDD...

Tommorow I'll also try how this test build will react when I'll not have any settings on mass or MC,
and few other things...

BTW I've also asked, if someone with HDD or SMB can try it here:
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-43#post-207461.
If someone will test it I'll try to post results here.

[KrahJohlito]

Gah, think I’ll have to tweak it a little and before sysCheckMC try open folder on either MC.. otherwise in that build I just realised... it will default to mc0 every time even if you have 2 mcs inserted and mc1 has an OPL folder.. easy fix

[J013k]

It seems that this issue has been fixed.