Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and add notifications feature #222

Merged
merged 5 commits into from Sep 22, 2019
Merged

Small fixes and add notifications feature #222

merged 5 commits into from Sep 22, 2019

Conversation

Tupakaveli
Copy link
Contributor

@Tupakaveli Tupakaveli commented Sep 21, 2019 •
edited

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

  • SFX code cleanup.

  • Fix font not being rendered for custom language when loaded from manually started device.

  • Add notifications feature - disabled by default.

  • Standardise English language strings - use title case for menu/settings items, use sentence case for messages/hints.

Updated test build: https://www.sendspace.com/file/rsjzc7

KrahJohlito and others added 2 commits September 21, 2019 22:39
@KrahJohlito @Tupakaveli
Small code clean ups, lang fix... add notifications (optional) (#10)
94f2ed3 
* sfx: code clean up

* lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device

* gui: add notifications
@Tupakaveli
Try to standardise English language strings
2f8cc62
@Jay-Jay-OPL
Copy link
Contributor

Please don't forget to also update the following template file: lng\lang_English.lng

I believe the protocol is whenever updating the lang.c file, you must also make those changes in the lang_English.lng file, so later translators have an English template to follow.

@Tupakaveli
Copy link
Contributor Author

@Jay-Jay-OPL Thanks, will do it tomorrow.

KrahJohlito and others added 2 commits September 22, 2019 13:36
@KrahJohlito @Tupakaveli
Reduce notifications code (#12)
8837305 
* sfx: code clean up

* lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device

* gui: add notifications

* gui: reduce notifications code
@Tupakaveli
Update English language template
bf68d79
@KrahJohlito
Copy link
Member

KrahJohlito commented Sep 22, 2019 •
edited

@ElPatas1
This is ready when you’ve had a chance to test.

Commits added for English Template & more efficient notifications code.

@J013k J013k mentioned this pull request Sep 22, 2019
Closed
@J013k
Copy link
Contributor

J013k commented Sep 22, 2019

I've tried this test version yesterday.
It seems that thm & lng bug when the device will be manually initialised has been fixed.

I can even get 3 notification at the same time when the device will be automatically started,
so thanks for that.
I mean:
Cfg has been loaded from...
Lng has been loaded from...
Thm has been loaded from...

Although I didn't notice notification when the device will be manually initialize.
I mean, when I'll start device (e.g. USB),
lng & thm will be loaded, but there will not be any notification from lng or thm were loaded from.

Anyway thanks for current progress.

@ElPatas1
Copy link
Contributor

Hello,

the new real strings or changed in lang.c for do changes in the custom
translations are only this two ones right?

Settings saved to %s
Enable notifications

Please confirm this.

And if the notifications is supposed to work also when the devices
are initialized manually, it would be convenient to fix it before the merge.

Best regards.

@Tupakaveli
Copy link
Contributor Author

@ElPatas1 also %s loaded from %s

The other changes were just for aesthetic reasons.

Best regards.

@TnA-Plastic
Copy link

TnA-Plastic commented Sep 22, 2019 •
edited

If it is merely a call to the new notification-function which is missing after manual initialization, I also hope for them to be added, but if it is more work I think it should be merged and a fix for the manual devices can be pushed later as well. ;)

But it is great to have the new notification-feature as well as the fixes! Can't wait for it being merged with or without showing the manually started devices.

Maybe it was left out intentionally for the manual devices?!

@KrahJohlito @Tupakaveli
notifications: show upon manual device init, if thm or lang changed (#13
5609c75 
)

* sfx: code clean up

* lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device

* gui: add notifications

* gui: reduce notifications code

* notifications: show upon manual device init, if thm or lang changed
@KrahJohlito
Copy link
Member

Ok done, sorry forgot all about manual device init.. added now.

@TnA-Plastic
Copy link

Great! :)

@Tupakaveli
Copy link
Contributor Author

@J013k updated test build.

@J013k
Copy link
Contributor

J013k commented Sep 22, 2019 •
edited

https://media2.giphy.com/media/dJezVlwfVulTykjRQj/source.gif

Thanks!
With today's build I don't have any problems.
I mean additional problems.

Anyway thanks once again.
Best regards.

EDIT: Removed unrelated content.

@TnA-Plastic
Copy link

True, but those are not related to the pull requests here and to the notification-feature, so I am all for a merge!

@ElPatas1 ElPatas1 merged commit cf40031 into ps2homebrew:master Sep 22, 2019
@ElPatas1
Copy link
Contributor

@Tupakaveli, thank you i not saw it.
@KrahJohlito, tested the test build and merged, thank you.

Best regards.

AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
@ElPatas1
Merge pull request #222 from Tupakaveli/master
83b9793 
Small fixes and add notifications feature
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@ElPatas1
Merge pull request ps2homebrew#222 from Tupakaveli/master
d3288a6 
Small fixes and add notifications feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Tupakaveli @Jay-Jay-OPL @KrahJohlito @J013k @ElPatas1 @TnA-Plastic