Guard let else return as a one liner?

[mokagio]

In the codebase we're using two different styles of early returns:

guard condition else { return }

and

guard condition else {
  return
}

We should pick one and stick to it.

[mokagio]

+1 this for the oneliner

[mokagio]

+1 this for the... newliner (?)

[cuteiosdev]

I think there's a bit of nuance here. When we need to do something as well as return, I think it should be the newline option. When it's just return, it should be the same line as the last guard statement.

[TimKregerIflix]

Although if we go with newliner it removes the nuance.

[adriaan]

In defence of newliner: it does make it easier to set breakpoints. (though you could always make it a newliner temporarily if you need to set a breakpoint).

[TimKregerIflix]

Yeah thats my primary reason @adriaan it just makes it easier when doing complex traces

[mokagio]

I think there's a bit of nuance here. When we need to do something as well as return, I think it should be the newline option. When it's just return, it should be the same line as the last guard statement.

Sure. The code example only has { return } and that was what the question was about. Although I didn't state anywhere 😳 .