Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec/controllers/meetings_controller_spec.rb to spec/request/meeting_spec.rb #1828

Closed
bennpham opened this issue Aug 26, 2020 · 3 comments

Comments

@bennpham
Copy link
Member

Description

Controller Specs had been obsolete since Rails 5. It is best practice to create request spec instead of controller spec as recommended by the Rspec team.

Recommended Reading:

Resources on Request Spec formatting:

Original Issue: #1815


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@chethanagopinath
Copy link

Hi, was wondering if this was okay for me to pick up :)

@chethanagopinath chethanagopinath self-assigned this Oct 7, 2021
@kkreine
Copy link

kkreine commented Dec 7, 2021

Hey @chethanagopinath, are you still working on this issue? If not, I'm happy to pick this up

@chethanagopinath
Copy link

Hi @kkreine took a bit of a break but I'll get to working on it this weekend, if I'm unable to figure it out, will tag you so that you could pick it up - hope that's okay 💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants