Refactor RSpec Controller Specs to Request Specs

[bennpham]

Description

Looking through the project, I notice that we use controller specs rather than request specs. Since we're on Rails 6 and reading through this Stackoverflow discussion in regards to controller specs vs request specs, it seems that controller specs are obsolete now.

Some pros and cons listed in this medium article mentions that controller specs methods such as assigns and assert_template are deprecated now as well and request spec is what is recommended by Rspec and test the entire stack. Request spec since Rails 5 are now faster as well.

Refactoring all the controller specs would be a large PR on its own though.

Request spec documentation on RelishApp: https://relishapp.com/rspec/rspec-rails/v/4-0/docs/request-specs/request-spec

---

• Refactor spec/controllers/groups/memberships_controller_spec.rb to spec/request/groups/membership_spec.rb #1816
  Refactor spec/controllers/groups/memberships_controller_spec.rb to spec/request/groups/membership_spec.rb

• Refactor spec/controllers/meetings/google_calendar_event_controller_spec.rb to spec/request/meetings/google_calendar_event_spec.rb #1817 Refactor spec/controllers/meetings/google_calendar_event_controller_spec.rb to spec/request/meetings/google_calendar_event_spec.rb

• Refactor spec/controllers/users/invitations_controller_spec.rb to spec/request/users/invitation_spec.rb #1818 Refactor spec/controllers/users/invitations_controller_spec.rb to spec/request/users/invitation_spec.rb

• Refactor spec/controllers/allies_controller_spec.rb to spec/request/allyship_spec.rb #1819 Refactor spec/controllers/allies_controller_spec.rb to spec/request/allyship_spec.rb

• Refactor spec/controllers/care_plan_contacts_controller_spec.rb to spec/request/care_plan_contact_spec.rb #1820 Refactor spec/controllers/care_plan_contacts_controller_spec.rb to spec/request/care_plan_contact_spec.rb

• Refactor spec/controllers/care_plan_controller_spec.rb to spec/request/care_plan_spec.rb #1821 Refactor spec/controllers/care_plan_controller_spec.rb to spec/request/care_plan_spec.rb

• Refactor spec/controllers/categories_controller_spec.rb to spec/request/category_spec.rb #1822
  Refactor spec/controllers/categories_controller_spec.rb to spec/request/category_spec.rb

• Refactor spec/controllers/comment_controller_spec.rb to spec/request/comment_spec.rb #1823 Refactor spec/controllers/comment_controller_spec.rb to spec/request/comment_spec.rb

• Refactor spec/controllers/errors_controller_spec.rb to spec/request/error_spec.rb #1824
  Refactor spec/controllers/errors_controller_spec.rb to spec/request/error_spec.rb

• Refactor spec/controllers/groups_controller_spec.rb to spec/request/group_spec.rb #1825 Refactor spec/controllers/groups_controller_spec.rb to spec/request/group_spec.rb

• Refactor spec/controllers/locales_controller_spec.rb to spec/request/locale_spec.rb #1826 Refactor spec/controllers/locales_controller_spec.rb to spec/request/locale_spec.rb

• Refactor spec/controllers/medications_controller_spec.rb to spec/request/medication_spec.rb #1827 Refactor spec/controllers/medications_controller_spec.rb to spec/request/medication_spec.rb refactoring

• Refactor spec/controllers/meetings_controller_spec.rb to spec/request/meeting_spec.rb #1828 Refactor spec/controllers/meetings_controller_spec.rb to spec/request/meeting_spec.rb refactoring

• Refactor spec/controllers/moments_controller_spec.rb to spec/request/moment_spec.rb #1829
  Refactor spec/controllers/moments_controller_spec.rb to spec/request/moment_spec.rb

• Refactor spec/controllers/moods_controller_spec.rb to spec/request/mood_spec.rb #1830 Refactor spec/controllers/moods_controller_spec.rb to spec/request/mood_spec.rb

• Refactor spec/controllers/notifications_controller_spec.rb to spec/request/notification_spec.rb #1831 Refactor spec/controllers/notifications_controller_spec.rb to spec/request/notification_spec.rb

• Refactor spec/controllers/omniauth_callbacks_controller_spec.rb to spec/request/omniauth_callback_spec.rb #1832 Refactor spec/controllers/omniauth_callbacks_controller_spec.rb to spec/request/omniauth_callback_spec.rb

• Refactor spec/controllers/pages_controller_spec.rb to spec/request/page_spec.rb #1833 Refactor spec/controllers/pages_controller_spec.rb to spec/request/page_spec.rb

• Refactor spec/controllers/profile_controller_spec.rb to spec/request/profile_spec.rb #1834 Refactor spec/controllers/profile_controller_spec.rb to spec/request/profile_spec.rb

• Refactor spec/controllers/pusher_controller_spec.rb to spec/request/pusher_spec.rb #1835 Refactor spec/controllers/pusher_controller_spec.rb to spec/request/pusher_spec.rb

• Refactor spec/controllers/registrations_controller_spec.rb to spec/request/registration_spec.rb #1836 Refactor spec/controllers/registrations_controller_spec.rb to spec/request/registration_spec.rb

• Refactor spec/controllers/reports_controller_spec.rb to spec/request/report_spec.rb #1837 Refactor spec/controllers/reports_controller_spec.rb to spec/request/report_spec.rb

• Refactor spec/controllers/search_controller_spec.rb to spec/request/search_spec.rb #1838
  Refactor spec/controllers/search_controller_spec.rb to spec/request/search_spec.rb

• Refactor spec/controllers/secret_shares_controller_spec.rb to spec/request/secret_share_spec.rb #1839 Refactor spec/controllers/secret_shares_controller_spec.rb to spec/request/secret_share_spec.rb

• Refactor spec/controllers/strategies_controller_spec.rb to spec/request/strategy_spec.rb #1840 Refactor spec/controllers/strategies_controller_spec.rb to spec/request/strategy_spec.rb

---

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

[welcome]

Thank you for opening this issue with us! If you haven't already, please follow these next steps to officially join our contributor community.

[julianguyen]

Hey @bennpham, thanks for calling this out! I think we should go ahead with your suggestion and look into refactoring to request specs! I recommend creating issues for all the different files so people can easily assign them to themselves.

[bennpham]

@julianguyen Sounds good. Should I make a handful of issues for each file and link it to this issue or rename this issue into one of the file and copy the description for each separate new issue?

[julianguyen]

Yeah I think you can just link it to this main issue to save time! Thanks!