Refactor applications controller spec

[camillevilla]

Hi! Our application_controller_spec.rb has soo many tests. Yay! But it could take advantage of some shared examples, let statements, etc. This could make the code less repetitive and easier to read if you're not familiar with the file.

The wonderful @whyderrick has offered to help out with this effort. If anyone is interested in pairing and/or doing some analysis and splitting up work, comment here or on the #dev channel on Slack.

[asquare14]

I want to work on this !

[whyderrick]

@asquare14 hey Atibhi! I'll be working on this tomorrow, but I'm in SF so it'll be sometime between 00:00 and 7:00 Bangalore time. It might be tough to pair, but I'd love for you to do the code review or to pick up on it if I don't finish tomorrow.

[asquare14]

@whyderrick That would be cool! 😊

[asquare14]

@whyderrick What is the progress?

[vildevev]

Hi, I'm willing to work on this issue @camillevilla

[camillevilla]

@vildevev did a great job of starting this refactor (see #900). We now have some shared examples (let and before) blocks that folks can try using.

Other ideas for refactoring:

• move additional variables into shared examples with let
  • mood
  • category
  • moment
  • strategy
  • new_allies
• extract helpers to another file (e.g. make creating + sign_in user a single method)
• find a DRYer way to create categories that have similar values. Is there a shorter way to create new_category1, new_category2 etc. when they all have the same userid?

Notes: Folks should feel free to claim one of these items by commenting on this issue. I highly recommend picking one bullet point and submitting a small PR first. It's better to move a little work forward than to take on the whole thing.

[StaphSynth]

Just letting people know, I'm currently working on refactoring these tests.