Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor application_controller_spec.rb #900

Merged
merged 4 commits into from Jun 2, 2018
Merged

Refactor application_controller_spec.rb #900

merged 4 commits into from Jun 2, 2018

Conversation

vildevev
Copy link
Collaborator

@vildevev vildevev commented Jun 2, 2018

#811 This PR:

  • Creates shared examples for the users
  • Makes variable naming more consistent
  • Sign in user in a before block

This dries up the code since the user was originally defined and signed in several times. There is still more work to do in the file, but hopefully, this is a good start.

@camillevilla camillevilla self-requested a review June 2, 2018 21:44
camillevilla
camillevilla approved these changes Jun 2, 2018
View reviewed changes
Copy link
Member

@camillevilla camillevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Great job, @vildevev! This makes the spec a lot DRYer and easier to read. I'll update #811 with suggestions for further refactoring.

@camillevilla camillevilla merged commit 63b5176 into ifmeorg:master Jun 2, 2018
@camillevilla camillevilla mentioned this pull request Jul 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillevilla camillevilla camillevilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vildevev @camillevilla