Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better use of semantic HTML for a11y #2040

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

julianguyen
Copy link
Member

Description

This PR does the following:

  • Improve use of semantic HTML in layout
    • Use landmark elements <header>, <main>, and <footer> correctly
  • Use H1 heading for PageTitle component

Manually inspected the sited (both signed in and not signed in experiences) and not breaking changes to the UI 馃帀

GIF of an animated skeleton and ghosts dancing aw yee


Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

@julianguyen julianguyen merged commit 4b97b1f into main Oct 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the better-semantic-layout branch October 19, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant