Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Added Visual indicator in story component #2157

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

nikhilbhatt
Copy link
Contributor

Description

  1. Added visual indicator in story component
  2. key icon will be shown at the end of story component.
  3. Key icon will display a text on hover. i.e. "Secret Share link created"

More Details

  1. Only if secret share link is generated than only the icon will displayed.

Corresponding Issue

#2144

Screenshots

image


Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

@welcome
Copy link

welcome bot commented Oct 8, 2022

Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack.

Copy link
Member

@julianguyen julianguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking this on! This looks generally good to me, can you rebase from main so that the continuous integration (CI) build runs? It looks like it timed out or stopped for some odd reason.

@nikhilbhatt
Copy link
Contributor Author

@julianguyen rebased.

Copy link
Member

@julianguyen julianguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks so much 🎉💃

@julianguyen julianguyen merged commit 0a4845e into main Oct 9, 2022
@welcome
Copy link

welcome bot commented Oct 9, 2022

Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page.

@delete-merged-branch delete-merged-branch bot deleted the added_secret_share_link_info branch October 9, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants