Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updateruby #477

Merged
merged 1 commit into from Jul 5, 2017
Merged

Updateruby #477

merged 1 commit into from Jul 5, 2017

Conversation

SophieRoseMcDonald
Copy link
Collaborator

Updated Ruby version 2.3.1 to Ruby 2.3.4 to support Docker on Ubuntu OS

@HashNotAdam
Copy link
Collaborator

Did you intend to include that first commit?
This PR does a lot more than just update Ruby

@julianguyen
Copy link
Member

julianguyen commented Jul 4, 2017

Agreed with Adam! Please remove the commits unrelated to upgrading to Ruby and put them into another pull request :) Don't forget to rebase from master.

Also just to confirm, did this change fix the problem with running Docker? ^^

Copy link
Collaborator

@HashNotAdam HashNotAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM
Docker is now booting as expected

@julianguyen julianguyen merged commit a6214e6 into ifmeorg:master Jul 5, 2017
@jnamster jnamster deleted the updateruby branch July 12, 2017 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants