Clean up code duplication in rails js #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
force-pushed
the
clean-up-code-duplication-in-rails-js
branch
from
5f5a71f
to
ca6fc13
Compare
julianguyen
force-pushed
the
clean-up-code-duplication-in-rails-js
branch
4 times, most recently
from
c84da57
to
2ee200c
Compare
julianguyen
force-pushed
the
clean-up-code-duplication-in-rails-js
branch
from
2ee200c
to
fc4157a
Compare
julianguyen
force-pushed
the
clean-up-code-duplication-in-rails-js
branch
2 times, most recently
from
32d8ad2
to
a5e5c78
Compare
julianguyen
force-pushed
the
clean-up-code-duplication-in-rails-js
branch
from
a5e5c78
to
f16a1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be unit tests for
form_processing.js, there's already an issue for this (#363). I will probably work on this at a later time 馃檭. I added basic acceptance tests for now.Created an issue for getting rid of JSHint and using ESLint everywhere. I wanted to use string interpolation and arrow functions but arg couldn't 馃ぃ