Client code cleanup: re-organize file structure, set up prettier #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
commented
Jul 22, 2018
| @@ -91,7 +93,8 @@ | |||
| "karma-spec-reporter": "^0.0.32", | |||
| "karma-webpack": "^2.0.4", | |||
| "node-sass": "^4.5.3", | |||
| "optimize-css-assets-webpack-plugin": "^3.1.1", | |||
| "optimize-css-assets-webpack-plugin": "^5.0.0", | |||
There was a problem hiding this comment.
Doesn't technically need to be updated, I was trying to re-enable it but it still wasn't working. Will try again in a follow up PR.
julianguyen
force-pushed
the
some-client-code-cleanup
branch
from
2480901
to
8ab9a81
Compare
julianguyen
force-pushed
the
some-client-code-cleanup
branch
from
8ab9a81
to
f053855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work for cleaning up code in the client
yarn lintThere will be future PRs with more cleanup :)