bug: plugin components configuration incorrectly pass into plugin

ifnode · Dec 21, 2017 · a9bd549 · a9bd549
1 parent 496231d
commit a9bd549
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/core/application/ComponentsBuilder.js b/core/application/ComponentsBuilder.js
@@ -83,8 +83,12 @@ ComponentsBuilder.prototype.build_component = function build_component(component
         }
 
         component_config.name = component_config.name || component.name;
+        component_config.config = _defaults(
+            component_config.config || {},
+            (this._components_configs[component_config.name])
+        );
 
-        component = new component(_defaults(component_config, this._components_configs[component_config.name]));
+        component = new component(component_config);
     }
 
     return component instanceof Component ?

diff --git a/examples/plugins/config/plugins.js b/examples/plugins/config/plugins.js
@@ -0,0 +1,10 @@
+module.exports = {
+    components: {
+        PluginComponent: {
+            key1: 'value1'
+        },
+        PluginClassComponent: {
+            key2: 'value2'
+        }
+    }
+};
diff --git a/test/plugins.js b/test/plugins.js
@@ -8,7 +8,8 @@ var IFNode = require('..');
 
 var app = IFNode({
     project_folder: Path.resolve(__dirname, '../examples/plugins'),
-    alias: 'plugins'
+    alias: 'plugins',
+    environment: 'plugins'
 });
 
 app.register([
@@ -47,4 +48,9 @@ describe('Plugins', function() {
             app.component('PluginComponent')
         );
     });
+
+    it('should has correct configurations for plugins', function() {
+        Should.deepEqual(app.component('PluginComponent').config, app.config.components.PluginComponent);
+        Should.deepEqual(app.component('PluginClassComponent').config, app.config.components.PluginClassComponent);
+    });
 });