Fix spec that pointed to wrong version of rails #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods with boolean return values come back from sg as `["true", "false"]` where previously they were `undefined` Some other methods with boolean return values come back from sg as `"Object"` were previously they were `undefined`
These were presumably not previously identified as problems because the rails7 spec was pointing to rails6/routes
Validating the presence of methods is fast, running rspec is slow (especially in CI). List all of the methods that are expected based on a yaml definition but are missing in one test's output, rather than failing when only one method is missing.
iftheshoefritz
force-pushed
the
fix-rails7-routing-spec
branch
from
0cdca10
to
46d2377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec should have pointed to rails7/routes.yml instead of rails6/routes.yml