New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API calls with only one or two parameters should not require a struct parameter #3

Open

ifvictr opened this issue Apr 15, 2021 · 0 comments

Labels

Owner

ifvictr commented Apr 15, 2021 •

edited

Loading

Example:

client := clubhouse.New()

// Current
client.StartPhoneNumberAuth(&clubhouse.StartPhoneNumberAuthParams{PhoneNumber: "+1…"})

// Proposed
client.StartPhoneNumberAuth("+1…")

If any additional parameters are added in the future, let the user pass a parameter struct like so:

client.StartPhoneNumberAuth("+1…", &clubhouse.StartPhoneNumberAuthParams{…})

I'm not sure how the best way to make this optional would be besides passing nil, which seems ugly.

The text was updated successfully, but these errors were encountered:

ifvictr added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment