Change BaseTrack attributes to Object attributes #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the attributes are used after object initialisation only, so there is no reason to keep them as Class attributes. Keeping them as class attributes instead causes ifzhang#79 This should fix ifzhang#79 and should not affect any other part. Have checked that we always call `self.next_id()` and never call `BaseTrack.next_id()` i.e., no need for it to be a static method anymore, since all the attributes are now object attributes.
|
Yes. I am only changing how the attributes are saved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the attributes are used after object initialisation only, so there is no reason to keep them as Class attributes.
Keeping them as class attributes instead causes #79
This should fix #79 and should not affect any other part.
Have checked that we always call
self.next_id()and never callBaseTrack.next_id()i.e., no need for it to be a static method anymore, since all the attributes are now object attributes.Fixes #79