-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expandir tests y Actions #2
Comments
Con relación a #1, se podría agregar un test con el parámetro de campus, falta coverage. |
agucova
added a commit
to agucova/BC_API
that referenced
this issue
Jun 2, 2020
As commented in igbasly#2, this adds flake8 and pytest.py to a Github Actions pipeline. Only errors on failed tests, syntax errors or undefined names. Pending LL update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Los tests tienen una implementación bastante obscura y Travis CI podría eliminarse a favor de una Github Action, lo que sería más transparente y mantenible.
Aprovechando Github Actions, un linter como flake8 o prospector podría ayudar. Estuve pasándome por el código y hay muchos
import
innecesarios, violaciones de PEP 8 y PEP 257, y harta lógica innecesaria.Véase aquí.
The text was updated successfully, but these errors were encountered: