Custom font #33
Merged
Custom font #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've just spent 10 minutes on writing code and another 30 on trying to please the linter 馃槚 the worst thing is as soon as I fix the problem it demands to rewrite the very thing I've just fixed in another way... would you mind adding some instructions on the correct workflow in |
3 tasks
|
Actually, that code is good, but I did not describe the ticket well enough. I will merge it and create another ticket describing it a bit more in detail. |
|
@all-contributors please add @merelj for code |
|
I've put up a pull request to add @merelj! 馃帀 |
|
Thank you for accepting the PR and sorry I didn't exactly get it right. 馃槚 I would gladly refactor it at some point in the future (not sure as to when though) if no one beats me to it 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue Custom Font
1st commit contains all the actual changes (component code + story)
2nd commit is just a result of me runningCI linter failed with this commit so I removed it. Fails anyway, tho...npm run lint -- --fixsince pre-commit hook would fail otherwise 馃槙Eager to hear your feedback; from what I can gather I should also add an example in codesandbox, but I'm not sure how to do it since I'd have to use new version of this package 馃