Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axis::matches is hardcoded to "x" #156

Closed
SignalWhisperer opened this issue Aug 15, 2023 · 0 comments · Fixed by #178
Closed

Axis::matches is hardcoded to "x" #156

SignalWhisperer opened this issue Aug 15, 2023 · 0 comments · Fixed by #178

Comments

@SignalWhisperer
Copy link

The Axis::matches function for the Layout struct currently receives a bool and then hardcodes this internally to "x". This limits greatly the matching that can be done for axes within subplots.

I believe the function should receive a string instead, allowing for far greater customization of axis matching as is supported by Plotly.js. [doc1, doc2]
@sebdotv sebdotv mentioned this issue Jan 18, 2024
Merged
andrei-ng added a commit to sebdotv/plotly that referenced this issue Jun 19, 2024
@andrei-ng
make layout axis matches take string as argument
2d3a5ff 
 - follow similar implemnetation as python plotly

fixes plotly#156

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setter for Axis::matches to take string arg sebdotv/plotly
1 participant
@SignalWhisperer