Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various test updates to make tests stable #79

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Various test updates to make tests stable #79

merged 3 commits into from
Nov 19, 2019

Conversation

igm
Copy link
Owner

@igm igm commented Nov 16, 2019

  • changed logic to wait for interrupt channel to close before checking receiver state rather to rely on lock mechanism
  • replaced time.Sleep with active loop to get session and receiver
  • some test updates to use testify/require to check for nil so that tests don't panic with nil

* changed logic to wait for interrupt channel to close before checking receiver state rather to rely on lock mechanism
* replaced time.Sleep with active loop to get session and receiver (relates to #66)
* some test updates to use testify to check for nil
@igm igm changed the title Various tests updates to make tests stable Various test updates to make tests stable Nov 16, 2019
@igm igm requested a review from FZambia November 16, 2019 14:49
@coveralls
Copy link

coveralls commented Nov 16, 2019

Coverage Status

Coverage decreased (-0.4%) to 94.51% when pulling 6b28a2b on issue-66 into bd2ed36 on master.

sockjs/handler_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@FZambia FZambia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments

h.sessionsMux.Unlock()
}
for exists := false; !exists; {
runtime.Gosched()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igm igm merged commit cd6986d into master Nov 19, 2019
@igm igm deleted the issue-66 branch November 19, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants