Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the type of receiver against the session #86

Closed
wants to merge 1 commit into from

Conversation

dombenson
Copy link

This is useful for diagnostics or logging when fallback mechanisms are in use

This is useful for diagnostics or logging when fallback mechanisms are in use
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 93.29% when pulling ad4c80a on dombenson:expose-receiver-type into cd6986d on igm:master.

@FZambia
Copy link
Collaborator

FZambia commented Mar 4, 2020

The implementation looks not thread-safe, also I think that for debugging purposes it's enough to just use session.Request().URL.Path

Maybe In general the helper like this could be useful but in my opinion it must also distinguish HTTP fallback type used - i.e. xhr-streaming, eventsource etc.

@igm
Copy link
Owner

igm commented Apr 26, 2020

fixed in v3

@igm igm closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants