add cuts in quasar redshift #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprafols
reviewed
Mar 13, 2023
py/picca/tests/test_3_cor.py
Outdated
| @@ -553,6 +553,477 @@ def test_xwick(self): | |||
|
|
|||
| return | |||
|
|
|||
| def test_cf_angl_2(self): | |||
There was a problem hiding this comment.
rename this functions with _zcuts instead
There was a problem hiding this comment.
we should rename the test files too
|
It does not make any sense, I cannot even reproduce the error in my computer. We did not change any line in the code rather than the names of functions and files. How is it possible that picca_xcf.py is failing now? |
|
Just renaming the test makes it work. I have no idea how that is possible. |
iprafols
approved these changes
Mar 14, 2023
|
Thank you very much Ignasi for finding the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for limiting the quasar redshift at the correlation level.
In the context of EDR, we decided to perform this instead of doing it at the delta extraction level.