Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmo class fix #996

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Cosmo class fix #996

merged 1 commit into from
Apr 25, 2023

Conversation

iprafols
Copy link
Collaborator

This is a quick fix for the Cosmo class to compute distances. This solves the immediate problem of reporting a value of H0=100 and having it as an optional parameter to the Cosmo class. This value is needed so that the return units are Mpc/h due to some obscure programming of this class. This should be fixed at some point.

Copy link
Contributor

@Waelthus Waelthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable choice for the moment. Should re-iterate on it in the future when implementing the cosmological model more properly

@Waelthus Waelthus merged commit 2f7222c into master Apr 25, 2023
@iprafols iprafols deleted the cosmo_class_fix branch April 25, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants