amalgamate aqua as the artisan #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review and proofread docs as a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that came to realization while working on ignatiusmb/aqua#37, as everything's starting to come together there and docs are getting updated, was that
aquais too low-level to be useful on its own and it didn't make much of a sense that the docs relied onmarquathat depends on an older version of the package that is being built. It was a cyclical mess that I considered having a monorepo to house both of these packages so that this problem would be easier to tackle, until I decided to sleep on it.I'm glad I did because amalgamating aqua here is a much better solution, why try to solve or workaround a problem when we can just make the problem obsolete, basically nonexistent in this case. This would however mean a breaking change, which the
v0.4.0milestone has been reserved for a lot of stuff that needs revamping. We could either shift all of them tov0.5.0, or take some more time to tackle everything in the milestone and overhaul the codebase, which could be answered later on.Closes #35
Closes #37
Ref ignatiusmb/aqua#37
Deprecate https://github.com/ignatiusmb/aqua after merging