lib/calendarium-romanum/temporale.rb (CalendariumRomanum::Temporale#holy_family): Changed to handle case when "a Sunday does not occur between December 25 and January 1" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oly_family): Changed to handle case when "a Sunday does not occur between December 25 and January 1" * lib/calendarium-romanum/temporale.rb (CalendariumRomanum::Temporale#holy_family): * spec/temporale_spec.rb: Changed to handle case when "a Sunday does not occur between December 25 and January 1".
igneus
requested changes
Jan 7, 2017
| year ||= @year | ||
| xmas = nativity(year) | ||
| if xmas.sunday? | ||
| return Date.new(year, 12, 30) # and only 1 reading before Gospel |
There was a problem hiding this comment.
Please remove the comment - lectionary is (and will always be) out of scope of this gem, so it's of no use here.
| @@ -221,6 +221,12 @@ | |||
| expect(c.rank).to eq CR::Ranks::FEAST_LORD_GENERAL | |||
| expect(c.title).to eq 'The Holy Family of Jesus, Mary and Joseph' | |||
| expect(c.colour).to eq CR::Colours::WHITE | |||
|
|
|||
| @t17 = described_class.new 2016 | |||
There was a problem hiding this comment.
Please make it a separate test case (it).
…ly Family Friday. * lib/calendarium-romanum/temporale.rb (CalendariumRomanum::Temporale#holy_family): No op. Removed comment about lectionary.
Changed to: - add link to English translation of Mysterii Paschalis - remove link to AAS.
Changed to fix broken link to English translation of Mysterii Paschalis. Was missing trailing 'L' in 'HTML'.
|
Once again - thanks a lot! |
|
@eddymul Just to let you know - this fix is finally deployed at http://calapi.inadiutorium.cz, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/calendarium-romanum/temporale.rb (CalendariumRomanum::Temporale#holy_family): Changed to handle case when "a Sunday does not occur between December 25 and January 1"
Changed to handle case when "a Sunday does not occur between December 25 and January 1".