Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start e2e testing #146

Merged
merged 1 commit into from
Aug 11, 2020
Merged

start e2e testing #146

merged 1 commit into from
Aug 11, 2020

Conversation

ilgooz
Copy link
Member

@ilgooz ilgooz commented Aug 11, 2020

  • added first e2e test to check app command.

related to #28.

* added first e2e test to check app command.
@ilgooz ilgooz requested a review from fadeev as a code owner August 11, 2020 13:10
@ilgooz ilgooz mentioned this pull request Aug 11, 2020
9 tasks
@ilgooz
Copy link
Member Author

ilgooz commented Aug 11, 2020

preview from e2e tests logs:
image

@fadeev
Copy link
Contributor

fadeev commented Aug 11, 2020

This is very cool! 🤩

@fadeev
Copy link
Contributor

fadeev commented Aug 11, 2020

@ilgooz should we add a couple of tests in this PR? Creating types, checking that a wallet has tokens, etc.?

@ilgooz
Copy link
Member Author

ilgooz commented Aug 11, 2020

@ilgooz should we add a couple of tests in this PR? Creating types, checking that a wallet has tokens, etc.?

How about merging this one as it is to create a base for e2e testing so we can both possibly add more e2e tests in separate branches?

In-fact we can make a list of e2e tests we need with TODO bullets in an issue and implement them in separate PR(s)?

Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@ilgooz ilgooz merged commit e7abdb0 into develop Aug 11, 2020
@ilgooz ilgooz deleted the feature/e2e branch August 11, 2020 14:53
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants