fix: installation of plugins for Go v1.18 and above
#2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes ignite#1163, but is not ideal... tooling binaries should be installed by running `go install [path]@[version]`, but protoc-gen-gocosmos uses a replace directive in the `go.mod` which is [incompatible with this method](golang/go#44840 (comment)). This fixes the problem for now, but adds plugin specific items to the go.mod of the scaffolded project, which shouldn't be there.
dave
requested review from
fadeev,
ilgooz,
lumtis,
Pantani and
ivanovpetr
as code owners
ilgooz
previously approved these changes
Mar 18, 2022
ilgooz
changed the title
v1.18 and above
ilgooz
added a commit
that referenced
this pull request
Mar 18, 2022
* Run go install after go get to install plugins This fixes #1163, but is not ideal... tooling binaries should be installed by running `go install [path]@[version]`, but protoc-gen-gocosmos uses a replace directive in the `go.mod` which is [incompatible with this method](golang/go#44840 (comment)). This fixes the problem for now, but adds plugin specific items to the go.mod of the scaffolded project, which shouldn't be there. * Update starport/pkg/cosmosgen/install.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* Run go install after go get to install plugins This fixes ignite#1163, but is not ideal... tooling binaries should be installed by running `go install [path]@[version]`, but protoc-gen-gocosmos uses a replace directive in the `go.mod` which is [incompatible with this method](golang/go#44840 (comment)). This fixes the problem for now, but adds plugin specific items to the go.mod of the scaffolded project, which shouldn't be there. * Update starport/pkg/cosmosgen/install.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* Run go install after go get to install plugins This fixes ignite#1163, but is not ideal... tooling binaries should be installed by running `go install [path]@[version]`, but protoc-gen-gocosmos uses a replace directive in the `go.mod` which is [incompatible with this method](golang/go#44840 (comment)). This fixes the problem for now, but adds plugin specific items to the go.mod of the scaffolded project, which shouldn't be there. * Update starport/pkg/cosmosgen/install.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2171, but is not ideal... tooling binaries should be installed by running
go install [path]@[version], but protoc-gen-gocosmos uses a replace directive in thego.modwhich is incompatible with this method. This fixes the problem for now, but adds plugin specific items to the go.mod of the scaffolded project, which shouldn't be there.