Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent map scaffolding from failing in an edge-case #2763

Closed
wants to merge 1 commit into from

Conversation

fadeev
Copy link
Contributor

@fadeev fadeev commented Aug 21, 2022

  • Added ReplaceIfExists
  • Switched map scaffolding from ReplaceOnce to ReplaceIfExists to handle an edge case

Edge-case: #2762

Not proposing this should be merged, just wanted to find the source of the issue.

Of course, we should just remove the handlers in the v0.46 version: #2764

@fadeev
Copy link
Contributor Author

fadeev commented Aug 29, 2022

Closing, because there will be no handler.go in the next version.

#2771

@fadeev fadeev closed this Aug 29, 2022
@Pantani Pantani deleted the fadeev/map-scaffolding branch May 22, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant