Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ICS chains in ts-client generation #3444

Merged
merged 11 commits into from
Apr 7, 2023

Conversation

ratik
Copy link
Contributor

@ratik ratik commented Feb 26, 2023

There is a Replicated Security feature introduced recently. So this one means that chain won't have staking module and will rely on provider security(ie validators/staking).

This PR consist of detection if the app has staking module and generation logic for ts-client

Copy link
Collaborator

@clockworkgr clockworkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .go file changes look ok I think. WIll let @ilgooz and co. double check those.

The client.ts.tpl changes are all part of the function that "suggests" a new chain to Keplr.
Has Keplr updated/documented use of this function for ICS chains yet or is this simply what we expect it to look like?

@ratik
Copy link
Contributor Author

ratik commented Mar 6, 2023

The client.ts.tpl changes are all part of the function that "suggests" a new chain to Keplr. Has Keplr updated/documented use of this function for ICS chains yet or is this simply what we expect it to look like?

As for now they are aware of this issue. I've created an github issue suggesting making stakeCurrency optional. Anyway after possible new Keplr API changes introduced there won't be much changes needed to Ignite

@clockworkgr
Copy link
Collaborator

The client.ts.tpl changes are all part of the function that "suggests" a new chain to Keplr. Has Keplr updated/documented use of this function for ICS chains yet or is this simply what we expect it to look like?

As for now they are aware of this issue. I've created an github issue suggesting making stakeCurrency optional. Anyway after possible new Keplr API changes introduced there won't be much changes needed to Ignite

ok cool.

we might as well update/revisit this when we have some more details

@ratik ratik requested a review from ilgooz as a code owner March 17, 2023 12:25
@ratik ratik requested review from jeronimoalbi and clockworkgr and removed request for tbruyelle, jeronimoalbi and clockworkgr March 21, 2023 05:18
@jeronimoalbi
Copy link
Member

@ratik would you add an entry for the feature to the changelog.md file?

@ratik ratik requested a review from jeronimoalbi March 23, 2023 08:37
jeronimoalbi
jeronimoalbi previously approved these changes Mar 23, 2023
@ratik ratik requested a review from clockworkgr March 27, 2023 10:01
changelog.md Outdated Show resolved Hide resolved
@jeronimoalbi jeronimoalbi merged commit f68a0c2 into ignite:main Apr 7, 2023
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* feat: support ICS chains

* feat: reverse condition to make IsConsumerChain false by default

* docs: update changelog

* docs: update changelog

* docs: small changelog.md section fix

---------

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants