Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled create CRUD button if not logged in #228

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

mihailmarcu
Copy link
Contributor

Description & Context

If we do not have authorization, we should not allow the creation and disable the button

How To Test

  1. Open the Data section;
  2. The "Create" button should be disabled;
  3. Connect with Keplr;
  4. The button must be active;

Linked issue

Closes #203

@mihailmarcu mihailmarcu self-assigned this Feb 22, 2022
@mihailmarcu mihailmarcu added the enhancement Improvement over existing feature label Feb 22, 2022
@fadeev
Copy link
Contributor

fadeev commented Feb 22, 2022

I guess I'm missing something, but for the following type:

syntax = "proto3";
package cosmos.hello.hello;

option go_package = "github.com/cosmos/hello/x/hello/types";

message Post {
  uint64 id = 1;
  string title = 2; 
  string body = 3; 
  string creator = 4;
}

I'm using the following template:

<template>
  <!-- Uncomment the following component to add a form for a `modelName` -->
  <SpCrud store-name="cosmos.hello.hello" item-name="Post" />
</template>

<script>
import { SpCrud } from "@starport/vue"
export default {
  name: 'Data',
  components: {SpCrud}
}
</script>

And the "Data" page is empty.

@fadeev fadeev changed the title #203: Disabled create CRUD button if not logged in fix: Disabled create CRUD button if not logged in Feb 22, 2022
@mihailmarcu mihailmarcu merged commit 92a4947 into develop Feb 22, 2022
@mihailmarcu mihailmarcu deleted the feature/203_disable_button_crud branch February 23, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ui): disable the button (crud)
3 participants