fix: Inputs UI improvements and selected tokens distance #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailmarcu
requested review from
fadeev,
marinhoarthur and
Matthews3301
as code owners
fadeev
changed the title
marinhoarthur
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Context
The input field for the modal edit did not cover the Figma design, the input field needed to be polished and the behavior improved. It was also necessary to improve the distance between the selected tokens for transfer.
How To Test
Open the Data section;
Connect with Keplr;
If you don't have items created, create them and click on the three dots icon after to access the menu;
Click "Edit" action;
The modal window that appears should display the correct design of the inputs;
Open the Portfolio section;
Connect with Keplr;
Choose two tokens to transfer (if you don't have at least two type, you can't test, add another token using cli or other methods to test it correctly);
The distance between the two selected tokens must be correct;
Linked issue
Closes #205, closes #206