-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add slot to override navbar logo #239
Conversation
@mihailmarcu please review. |
Hey @marinhoarthur, @mikeeus, Also, some developers will want to have different dark theme images or use the |
@mihailmarcu That's a great idea! I've updated the PR to replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mikeeus,
Thanks for your input on improving the navigation bar component. The changes look good on our end.
@marinhoarthur can you, please, review, so we can merge if it looks good. Thanks! |
closes #238 |
Adds a prop called logo of type NavbarLogo that lets the user override the default logo.
Addresses #238