Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style in the token list (modal) #257

Merged
merged 5 commits into from
Mar 25, 2022
Merged

fix: style in the token list (modal) #257

merged 5 commits into from
Mar 25, 2022

Conversation

mihailmarcu
Copy link
Contributor

Closes: #242

@mihailmarcu mihailmarcu self-assigned this Mar 11, 2022
marinhoarthur
marinhoarthur suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@marinhoarthur marinhoarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use what Vue is recommending?

image

@fadeev fadeev requested a review from darika-dev March 15, 2022 11:24
@fadeev
Copy link
Contributor

fadeev commented Mar 15, 2022

@darika-dev adding you as a reviewer, please, check out this PR 🙏

@mihailmarcu
Copy link
Contributor Author

Hey @here,
I removed the deprecated ::v-deep pseudo-class and used :deep() instead.

@fadeev fadeev requested a review from JoseRFelix March 17, 2022 11:01
@marinhoarthur marinhoarthur merged commit a9865e8 into develop Mar 25, 2022
@marinhoarthur marinhoarthur deleted the feature/242_token_list_modal branch March 25, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinhoarthur marinhoarthur marinhoarthur approved these changes

@fadeev fadeev Awaiting requested review from fadeev

@Matthews3301 Matthews3301 Awaiting requested review from Matthews3301

@darika-dev darika-dev Awaiting requested review from darika-dev

@JoseRFelix JoseRFelix Awaiting requested review from JoseRFelix

Assignees

@mihailmarcu mihailmarcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(ui): style in the token list (modal)
3 participants
@mihailmarcu @fadeev @marinhoarthur