Refactor code to use parameter, return type hints

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
igniter-labs · Jan 14, 2024 · 6806647 · 6806647
1 parent 4301986
commit 6806647
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/src/ApiResources/Webhooks.php b/src/ApiResources/Webhooks.php
@@ -9,7 +9,7 @@
  */
 class Webhooks extends ApiController
 {
-    public $implement = [
+    public array $implement = [
         \Igniter\Api\Http\Actions\RestController::class,
     ];
 

diff --git a/src/Extension.php b/src/Extension.php
@@ -44,7 +44,7 @@ public function boot()
         }
     }
 
-    public function registerSettings()
+    public function registerSettings(): array
     {
         return [
             'settings' => [
@@ -62,7 +62,7 @@ public function registerSettings()
      *
      * @return array
      */
-    public function registerPermissions()
+    public function registerPermissions(): array
     {
         return [
             'IgniterLabs.Webhook.ManageSetting' => [
@@ -72,7 +72,7 @@ public function registerPermissions()
         ];
     }
 
-    public function registerNavigation()
+    public function registerNavigation(): array
     {
         return [
             'tools' => [
@@ -89,7 +89,7 @@ public function registerNavigation()
         ];
     }
 
-    public function registerSchedule($schedule)
+    public function registerSchedule(string $schedule)
     {
         $schedule->command('webhook:cleanup')->name('Webhook Log Cleanup')->daily();
     }

diff --git a/src/Http/Controllers/Outgoing.php b/src/Http/Controllers/Outgoing.php
@@ -11,12 +11,12 @@
  */
 class Outgoing extends \Igniter\Admin\Classes\AdminController
 {
-    public $implement = [
+    public array $implement = [
         \Igniter\Admin\Http\Actions\FormController::class,
         \Igniter\Admin\Http\Actions\ListController::class,
     ];
 
-    public $listConfig = [
+    public array $listConfig = [
         'list' => [
             'model' => \IgniterLabs\Webhook\Models\Outgoing::class,
             'title' => 'lang:igniterlabs.webhook::default.outgoing.text_title',
@@ -26,7 +26,7 @@ class Outgoing extends \Igniter\Admin\Classes\AdminController
         ],
     ];
 
-    public $formConfig = [
+    public array $formConfig = [
         'name' => 'lang:igniterlabs.webhook::default.outgoing.text_form_name',
         'model' => \IgniterLabs\Webhook\Models\Outgoing::class,
         'request' => \IgniterLabs\Webhook\Requests\Outgoing::class,
@@ -50,7 +50,7 @@ class Outgoing extends \Igniter\Admin\Classes\AdminController
         'configFile' => 'outgoing',
     ];
 
-    protected $requiredPermissions = 'IgniterLabs.Webhook.*';
+    protected null|string|array $requiredPermissions = 'IgniterLabs.Webhook.*';
 
     public function __construct()
     {

diff --git a/src/Models/Settings.php b/src/Models/Settings.php
@@ -6,11 +6,11 @@
 
 class Settings extends Model
 {
-    public $implement = [\Igniter\System\Actions\SettingsModel::class];
+    public array $implement = [\Igniter\System\Actions\SettingsModel::class];
 
     // A unique code
-    public $settingsCode = 'igniterlabs_webhook_settings';
+    public string $settingsCode = 'igniterlabs_webhook_settings';
 
     // Reference to field configuration
-    public $settingsFieldsConfig = 'settings';
+    public string $settingsFieldsConfig = 'settings';
 }