OF-1660: Generate javadoc artifacts as part of the verify phase

[GregDThomas]

mvn verify will now generate javadoc and sources jar files too.

mvn package does not - as the generation can be slow which is a PITA during the dev/test cycle.

[GregDThomas]

Note; still requires the artifact to be moved to the right place.

[guusdk]

I'm not a big fan to attaching this to a Maven phase where this action is unexpected. Can't we instead use either a profile, or an explicit additional argument in the maven command?

[GregDThomas]

I hear what you're saying; the default phase for packaging javadoc/source files is, well, "package" - I pushed it back to verify to cut down the dev/test cycle time.

Does the CI build things with a specific profile? Could it do so?

[guusdk]

The CI does whatever is configured in the .travis.yml file. In the current state, the command that's executed is on line 13: script: mvn verify

It's deceptively easy to modify to whatever you want. :)

[GregDThomas]

OK, re-worked this. There's now a new "ci" profile, which generates sources and javadoc JAR files. That's called when running on Travis. This still requires the artifact to be moved to the right place.

[guusdk]

Thank you! Moving the artifact to the right place will first require us to move it into the Maven repository. If you have time left, maybe look at line 17?

[GregDThomas]

Well, I changed that line too, I think it's right, but may need to be merged before anything happens?

[guusdk]

It's probably a good thing that Travis does not deploy anything to our Maven repo based on an unmerged PR. :)