Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-1868: Cluster isMessageCarbonsEnabled and hasRequestedBlocklist to other nodes #1495

Closed
wants to merge 6 commits into from

Conversation

mightymop
Copy link
Contributor

isMessageCarbonsEnabled and hasRequestedBlocklist have to be clustered to other members too.

@mightymop
Copy link
Contributor Author

Also check this: igniterealtime/openfire-hazelcast-plugin#31

@mightymop mightymop changed the title Fix for OF-1868 OF-1868: Cluster isMessageCarbonsEnabled and hasRequestedBlocklist to other nodes Nov 1, 2019
@@ -68,6 +72,18 @@ public String getActiveList() {
public boolean isOfflineFloodStopped() {
return offlineFloodStopped;
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the comment? Not really necessary as git will show where/when it was added. Thanks!

}

/**
* Added for OF-1868
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this comment too)

@@ -81,6 +97,12 @@ public void writeExternal(ObjectOutput out) throws IOException {
ExternalizableUtil.getInstance().writeSafeUTF(out, activeList);
}
ExternalizableUtil.getInstance().writeBoolean(out, offlineFloodStopped);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@@ -94,5 +116,11 @@ public void readExternal(ObjectInput in) throws IOException, ClassNotFoundExcept
activeList = ExternalizableUtil.getInstance().readSafeUTF(in);
}
offlineFloodStopped = ExternalizableUtil.getInstance().readBoolean(in);

/**
* Added for OF-1868
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

mightymop added 5 commits November 24, 2019 19:41
…was not able to use only few of them.

Now you can provide ldap.searchFields and don't have to search over all fields in a search.
@GregDThomas
Copy link
Contributor

It looks to me like you're committing all your changes to master; there are changes in here now unrelated to OF-1868. You generally need to work on branches - you might want to have a look at https://guides.github.com/introduction/flow/ if you're unfamiliar with how branching works.

@mightymop
Copy link
Contributor Author

Ok so u wont commit the code until i splitted it into several branches? What should i do now? Btw. I have the codechanges running for 6 month now and they r running quite good.

@deleolajide
Copy link
Member

Ok so u wont commit the code until i splitted it into several branches?

You don't need to create several branches. Just a single one with all the changes concerning this issue OF-1868. That way it won't be affected by other stuff happening on your master repo :-)

@mightymop mightymop closed this Nov 24, 2019
@mightymop
Copy link
Contributor Author

I opened up the pull request from a new branch now:

#1534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants