New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OF-1868: Cluster isMessageCarbonsEnabled and hasRequestedBlocklist to other nodes #1495
Conversation
Also check this: igniterealtime/openfire-hazelcast-plugin#31 |
@@ -68,6 +72,18 @@ public String getActiveList() { | |||
public boolean isOfflineFloodStopped() { | |||
return offlineFloodStopped; | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the comment? Not really necessary as git will show where/when it was added. Thanks!
} | ||
|
||
/** | ||
* Added for OF-1868 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this comment too)
@@ -81,6 +97,12 @@ public void writeExternal(ObjectOutput out) throws IOException { | |||
ExternalizableUtil.getInstance().writeSafeUTF(out, activeList); | |||
} | |||
ExternalizableUtil.getInstance().writeBoolean(out, offlineFloodStopped); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
@@ -94,5 +116,11 @@ public void readExternal(ObjectInput in) throws IOException, ClassNotFoundExcept | |||
activeList = ExternalizableUtil.getInstance().readSafeUTF(in); | |||
} | |||
offlineFloodStopped = ExternalizableUtil.getInstance().readBoolean(in); | |||
|
|||
/** | |||
* Added for OF-1868 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
…was not able to use only few of them. Now you can provide ldap.searchFields and don't have to search over all fields in a search.
…ally xmpp.muc.cleanup = false (part 2)
It looks to me like you're committing all your changes to master; there are changes in here now unrelated to OF-1868. You generally need to work on branches - you might want to have a look at https://guides.github.com/introduction/flow/ if you're unfamiliar with how branching works. |
Ok so u wont commit the code until i splitted it into several branches? What should i do now? Btw. I have the codechanges running for 6 month now and they r running quite good. |
You don't need to create several branches. Just a single one with all the changes concerning this issue OF-1868. That way it won't be affected by other stuff happening on your master repo :-) |
I opened up the pull request from a new branch now: |
isMessageCarbonsEnabled and hasRequestedBlocklist have to be clustered to other members too.