New Unit test that verify the implementation of ScramSha1SaslServer #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As of now, the new unit test fails. I have failed to find out how/why. I've created a PR in the hope that a review by someone else helps to identify the issue. |
|
@richmidwinter as the original author of the code under test, is this something that you fancy looking into? |
guusdk
force-pushed
the
unit-test-scramsha1saslserver
branch
from
b497dce
to
826a136
Compare
guusdk
force-pushed
the
unit-test-scramsha1saslserver
branch
from
826a136
to
ff4df4a
Compare
guusdk
force-pushed
the
unit-test-scramsha1saslserver
branch
from
ff4df4a
to
3afc711
Compare
|
Ah, found it. I was provisioning the AuthFactory with incorrectly formatted data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.