OF-2827: JDBCAuthProvider should not lowercase/trim provided username #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By lowercasing the input, a username with a capital letter can't be used. The closely related JDBCUserProvider does not lowercase/trim values. It is probably best that both providers treat usernames in the same way.
guusdk
added
the
backport 4.8
|
Seems reasonable to maintain the fidelity of the username. I can see an argument to maintain the trim, but I don't know whether |
Fishbowler
approved these changes
May 17, 2024
It likely isn't, but shouldn't that then be applied to where the user provides the input (eg: the login form)? |
|
Exactly that. Let's trust the user. |
|
Hehehe, let's not - but lets apply input validation near the input form maybe? |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By lowercasing the input, a username with a capital letter can't be used.
The closely related JDBCUserProvider does not lowercase/trim values. It is probably best that both providers treat usernames in the same way.
I'm wondering if we even need a configuration option to make this behavior configurable. Isn't it just plain 'wrong' to have inconsistent processing of the
usernamevalues - that's never going to work, is it?